slovo/.llm/reviews/BETA_23_RELEASE_REVIEW.md

4.7 KiB

Beta23 Release Review

Verdict: PASS with notes.

Findings

No blocking or non-blocking findings in the reviewed scope.

Scope Reviewed

  • scripts/render-stdlib-api-doc.js tier rendering.
  • scripts/check-stdlib-api-tiers.js tier gate.
  • scripts/release-gate.sh integration.
  • Generated docs/language/STDLIB_API.md.
  • docs/language/STDLIB_TIERS.md, README, release notes, roadmaps, and spec updates.
  • Compiler package version bump and compiler release documentation.

Acceptance Checklist

  • PASS: docs/language/STDLIB_TIERS.md defines the public tier labels and explains the current beta meaning. See docs/language/STDLIB_TIERS.md:21 through docs/language/STDLIB_TIERS.md:25.
  • PASS: The tier ledger marks JSON, loopback networking, random/time, and filesystem resource-handle helpers as experimental domains. See docs/language/STDLIB_TIERS.md:46 through docs/language/STDLIB_TIERS.md:49.
  • PASS: The tier ledger records concrete vector modules as beta-supported concrete lanes without claiming generic collection stability. See docs/language/STDLIB_TIERS.md:44.
  • PASS: The generated API catalog emits tier metadata and summary counts. See docs/language/STDLIB_API.md:6 through docs/language/STDLIB_API.md:24.
  • PASS: Generated catalog classification matches the beta23 contract: filesystem handle helpers are experimental in docs/language/STDLIB_API.md:115 through docs/language/STDLIB_API.md:119; std.json, std.net, std.random, and std.time are experimental in docs/language/STDLIB_API.md:195 through docs/language/STDLIB_API.md:240, docs/language/STDLIB_API.md:294 through docs/language/STDLIB_API.md:308, docs/language/STDLIB_API.md:425 through docs/language/STDLIB_API.md:432, and docs/language/STDLIB_API.md:540 through docs/language/STDLIB_API.md:547.
  • PASS: Concrete vector modules retain explicit no-generic-collection-freeze notes in generated output. Representative coverage is docs/language/STDLIB_API.md:549 through docs/language/STDLIB_API.md:554, with the same note repeated for the other concrete std.vec_* modules.
  • PASS: The renderer implements the tier map and emits per-module/per-helper tiers. See scripts/render-stdlib-api-doc.js:12 through scripts/render-stdlib-api-doc.js:46, scripts/render-stdlib-api-doc.js:245 through scripts/render-stdlib-api-doc.js:263, and scripts/render-stdlib-api-doc.js:297 through scripts/render-stdlib-api-doc.js:330.
  • PASS: The tier gate checks stale wording, summary tier definitions, experimental module/helper coverage, and vector boundary notes. See scripts/check-stdlib-api-tiers.js:47 through scripts/check-stdlib-api-tiers.js:80.
  • PASS: scripts/release-gate.sh runs syntax checks for both tier scripts and executes the tier checker after catalog rendering. See scripts/release-gate.sh:12 through scripts/release-gate.sh:16.
  • PASS: README, lib/std/README.md, language release notes, language roadmap, post-beta roadmap, and v1 spec link or describe the tier ledger and non-scope. Representative references: README.md:69 through README.md:79, lib/std/README.md:174 through lib/std/README.md:184, docs/language/RELEASE_NOTES.md:53 through docs/language/RELEASE_NOTES.md:69, docs/language/ROADMAP.md:109 through docs/language/ROADMAP.md:119, docs/POST_BETA_ROADMAP.md:121 through docs/POST_BETA_ROADMAP.md:132, and docs/language/SPEC-v1.md:268 through docs/language/SPEC-v1.md:279.
  • PASS: Documentation states beta23 is documentation/catalog tooling clarity only and does not add language, stdlib, runtime, stable schema, ABI/layout, or stable API behavior. See docs/language/STDLIB_TIERS.md:10 through docs/language/STDLIB_TIERS.md:15 and docs/language/STDLIB_TIERS.md:52 through docs/language/STDLIB_TIERS.md:68.
  • PASS: Compiler package version and compiler release docs are aligned to 1.0.0-beta.23. See compiler/Cargo.toml:3, compiler/Cargo.lock:7, docs/compiler/RELEASE_NOTES.md:15 through docs/compiler/RELEASE_NOTES.md:43, and docs/compiler/ROADMAP.md:126 through docs/compiler/ROADMAP.md:132.

Verification

Ran:

node --check scripts/render-stdlib-api-doc.js
node --check scripts/check-stdlib-api-tiers.js
./scripts/check-stdlib-api-tiers.js
git diff --check
rg -n '^- `experimental`' docs/language/STDLIB_API.md

Result: all focused checks passed. The rg inspection confirmed 58 experimental helper signatures across the expected filesystem-handle, JSON, loopback networking, random, and time surfaces.

Recommended before release tag:

./scripts/render-stdlib-api-doc.sh
./scripts/release-gate.sh

Note: run the full release gate after the generated catalog changes are staged or committed; the gate intentionally fails if docs/language/STDLIB_API.md has unstaged generated-doc drift.