Hermeticum/slovo
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
05ff5be5c5
slovo/.llm/reviews/BETA_12_RELEASE_REVIEW.md

2.6 KiB
Raw Blame History

1.0.0-beta.12 Release Review

Status: ready for publication after controller release gate.

Verdict

No blocking issues found in the current beta12 worktree. The slice is correctly framed as concrete vector source-helper parity and can proceed to the final publication gate.

Scope Checked

  • lib/std/vec_i64.slo exports and implements count_of, starts_with, without_prefix, ends_with, and without_suffix as ordinary source helpers over the existing std.vec.i64 runtime wrappers and staged helper surface.
  • lib/std/vec_f64.slo exports and implements count_of as an ordinary source helper; the existing f64 prefix/suffix helpers remain aligned.
  • Local fixture copies, explicit std.vec_i64 and std.vec_f64 examples, and mirrored language-doc examples import and exercise the new helpers.
  • Focused helper tests, source-search tests, and promotion-gate inventories now require the new exports and expected 20 test(s) passed fixture output.
  • README, roadmaps, release notes, SPEC-v1, regenerated STDLIB_API.md, the beta12 .llm scope note, and the compiler package version bump align on the 1.0.0-beta.12 concrete vector query and prefix parity scope.

Findings

No blockers.

  • Helper semantics match the existing concrete lanes: exact equality counts, empty prefix/suffix success, longer input rejection, mismatch rejection, exact removal to empty, and unmatched removal returning the original vector.
  • Release-facing text keeps the scope narrow: no source-language, runtime, typed-core, compiler-known stdlib/runtime-name, generic dispatch, map/set, iterator, mutable-vector, slice/view, ABI/layout, performance, or stable stdlib/API-freeze claim.
  • STDLIB_API.md is consistent with the current lib/std sources: 578 exported helper signatures total, with 36 each for std.vec_i64 and std.vec_f64.
  • Publication hygiene review found no beta12 private local path leakage in the touched release-facing text.

Verification

  • cargo test --manifest-path compiler/Cargo.toml --test standard_vec_i64_source_helpers_alpha --test standard_vec_f64_source_helpers_alpha --test standard_vec_i64_source_search_alpha --test standard_vec_f64_source_search_alpha: passed.

  • cargo fmt --manifest-path compiler/Cargo.toml --check: passed.

  • git diff --check: passed.

  • STDLIB_API.md was regenerated in an isolated copy and compared against the worktree copy: no diff.

  • ./scripts/release-gate.sh: passed after the beta12 release commit, including docs/API freshness, cargo fmt --check, full cargo test, ignored promotion gates, binary smoke, and LLVM smoke.