slovo/.llm/reviews/BETA_15_RELEASE_REVIEW.md

54 lines
2.4 KiB
Markdown

# 1.0.0-beta.15 Release Review
## Findings
No blocking findings.
- Ready for controller release gate. The beta15 candidate consistently scopes
this release as reserved generic collection boundary hardening plus a
collection ledger, without promoting executable generics, maps, sets,
generic stdlib dispatch, runtime names, ABI/layout, or stable API behavior.
- Evidence: the release contract preserves diagnostic shape/codes/schema while
allowing reserved-boundary prose rewording
(`.llm/BETA_15_RESERVED_GENERIC_COLLECTION_BOUNDARY_HARDENING.md:5`,
`.llm/BETA_15_RESERVED_GENERIC_COLLECTION_BOUNDARY_HARDENING.md:27`,
`.llm/BETA_15_RESERVED_GENERIC_COLLECTION_BOUNDARY_HARDENING.md:49`),
public docs describe the same boundary
(`README.md:86`, `docs/language/COLLECTIONS.md:12`,
`docs/language/COLLECTIONS.md:113`), and compiler docs mirror the
centralized-diagnostic scope (`docs/compiler/RELEASE_NOTES.md:28`,
`docs/compiler/ROADMAP.md:64`).
- Evidence: reserved diagnostic construction is centralized in
`compiler/src/reserved.rs:9`, `compiler/src/reserved.rs:62`,
`compiler/src/reserved.rs:77`, `compiler/src/reserved.rs:92`, and
`compiler/src/reserved.rs:107`; lowerer, formatter, and checker paths import
those helpers at `compiler/src/lower.rs:12`,
`compiler/src/formatter.rs:6`, and `compiler/src/check.rs:10`.
- Evidence: release gate wiring includes the focused beta15 test at
`scripts/release-gate.sh:68`, and the version bump is present in
`compiler/Cargo.toml:3` and `compiler/Cargo.lock:7`.
## Verification
- `cargo fmt --check`: passed.
- `cargo test --test reserved_generic_collection_beta15`: passed, 1 test.
- `cargo test --test diagnostics_contract`: passed, 1 test.
- `cargo test --test formatter`: passed, 16 tests.
- `cargo test --test project_mode`: passed, 36 tests.
- `rg -n "not supported in beta\\.9" compiler/src tests`: passed, no matches.
- `git diff --check`: passed.
Additional review scans:
- Current-stage stale beta14 scan across README/docs/.llm/Cargo metadata:
passed, no current-stage matches.
- Private/local publication text scan across README, docs, scripts, compiler
sources/tests, lib, examples, benchmarks, tests, and `.llm`: passed, no
matches.
## Residual Risk
Full release gate was not run by this reviewer because the requested scope was
focused review-only. Controller should still run `./scripts/release-gate.sh`
after accepting the candidate and before tagging/publishing.