slovo/.llm/reviews/BETA_25_RELEASE_REVIEW.md

3.1 KiB

Beta25 Release Review

Verdict: PASS.

Findings

No blocking or non-blocking findings in the re-reviewed scope.

The prior blocking finding is resolved. compiler/tests/user_project_conformance_beta25.rs now covers all 43 top-level fixture roots currently discovered under examples/projects/ and examples/workspaces/: 41 project fixtures plus 2 workspace fixtures. The test also asserts the matrix length, total discovered-test count, sorted path order, and exact inventory completeness against discovered top-level slovo.toml fixture roots.

Acceptance Checklist

  • PASS: The conformance matrix covers every current top-level slovo.toml fixture root under examples/projects/ and examples/workspaces/.
  • PASS: assert_matrix_inventory() asserts the 43-root count, 655 discovered tests, sorted repository-relative path order, exact discovered fixture inventory, and the full expected path/test/run matrix.
  • PASS: The test runs glagol check, glagol test --list, and stable glagol test for every matrix entry.
  • PASS: Deterministic env fixture handling is wired through configure_conformance_env(): expected env variables are set to stable values and intentionally-missing env variables are removed before each Glagol command.
  • PASS: scripts/release-gate.sh still runs cargo test --test user_project_conformance_beta25.
  • PASS: compiler/Cargo.toml and compiler/Cargo.lock both version glagol as 1.0.0-beta.25.
  • PASS: README, release notes, roadmaps, and the beta25 matrix doc continue to frame the release as tooling/conformance evidence without claiming language, runtime, stdlib, package-manager, stable-schema, ABI/layout, or performance changes.

Verification Commands

Ran:

git status --short
git diff --stat
sed -n '1,620p' compiler/tests/user_project_conformance_beta25.rs
find examples/projects -mindepth 2 -maxdepth 2 -name slovo.toml -printf '%h\n'
find examples/workspaces -mindepth 2 -maxdepth 2 -name slovo.toml -printf '%h\n'
find examples/projects -mindepth 2 -maxdepth 2 -name slovo.toml -printf '.' | wc -c
find examples/workspaces -mindepth 2 -maxdepth 2 -name slovo.toml -printf '.' | wc -c
rg -n "assert_eq!\(MATRIX\.len\(\), 43|discover_fixture_paths|configure_conformance_env|GLAGOL_STD_IMPORT_ENV_ALPHA_PRESENT|GLAGOL_STD_LAYOUT_LOCAL_ENV_ALPHA_PRESENT" compiler/tests/user_project_conformance_beta25.rs
git diff --check
cargo fmt --check
cargo test --test user_project_conformance_beta25

Results:

  • git diff --check: PASS.
  • cargo fmt --check: PASS.
  • cargo test --test user_project_conformance_beta25: PASS, 1 test passed.
  • Fixture inventory counts: 41 top-level project roots and 2 top-level workspace roots.
  • Matrix inventory assertion: covers 43 roots and 655 discovered tests.

Residual Risks

No release-blocking residual risks remain for this slice.

Final Gate Disposition

The controller reran the full release gate after staging the generated docs/language/STDLIB_API.md beta25 catalog update:

./scripts/release-gate.sh

Result: PASS. The gate reported:

release gate passed: docs, stdlib API catalog, fmt, tests, promotion, binary, and LLVM smoke checks completed