slovo/.llm/reviews/BETA_21_RELEASE_REVIEW.md

1.0.0-beta.21 Release Review

Scope: JSON Document Scalar Parsing Foundation.

Findings

No blocking findings.

The uncommitted beta21 candidate matches the release contract:

• lib/std/json.slo exports all eight source-authored parse_*_document_result helpers.
• Each document helper trims the whole input with trim_ascii, then delegates to the existing exact scalar value-token parser for the matching family.
• Direct compiler-known std.json.parse_*_document_result calls are not introduced, and no private __glagol_json_*document* runtime symbol is introduced.
• The explicit std.json example imports repo-root std.json and covers trimmed success, plain success, trailing non-whitespace failure, scalar token parsing, fields, arrays, objects, and 12 tests.
• The local JSON example imports local json, the local json fixture imports local string (trim_ascii), and it mirrors the same 12-test coverage.
• Compiler coverage includes the focused beta21 test, JSON facade inventory, promotion-gate alignment, release-gate wiring, package version bump, and the generated standard-library API catalog signatures.
• Release docs describe 1.0.0-beta.21 as released, and the source/docs scan did not find local/private publication text.

Verification

Commands run:

git diff --check
git diff --cached --check
bash -n scripts/release-gate.sh
cargo fmt --check --manifest-path compiler/Cargo.toml
cargo test --test standard_json_document_scalar_parsing_beta21
cargo test --test standard_json_source_facade_alpha
cargo test --test promotion_gate -- promotion_gate_artifacts_are_aligned

Results:

• standard_json_document_scalar_parsing_beta21: 2 passed.
• standard_json_source_facade_alpha: 2 passed.
• promotion_gate_artifacts_are_aligned: 1 passed.
• Formatting, shell syntax, and diff whitespace checks passed.
• Targeted stale-release/private-text scans over source/docs paths passed.

Not run by design for this review: full cargo test, ignored smoke tests, and the full release gate.