Hermeticum/slovo
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
98f81d2d59
slovo/.llm/reviews/BETA_19_RELEASE_REVIEW.md

2.0 KiB
Raw Blame History

1.0.0-beta.19 Release Review

Scope: Test Discovery And User-Project Conformance Foundation

Findings

No blocking findings.

The implementation matches the beta19 contract at the release-blocking level: glagol test --list <file|project|workspace> and legacy glagol --run-tests --list <file> route through checked discovery, avoid test body evaluation, preserve the existing discovery ordering, honor --filter <substring>, keep ordinary test output unchanged, and are wired into the release gate through cargo test --test test_discovery_beta19.

Non-Blocking Notes

  • Resolved during controller integration: unfiltered list output now prints the same summary suffix as filtered list output, including total_discovered, selected, passed, failed, skipped, and filter none.
  • Resolved during controller integration: the grammar typo in docs/POST_BETA_ROADMAP.md was corrected.

Verification Notes

Inspected:

  • Working tree status and beta19 diff across CLI parsing/dispatch, project test mode, test-runner listing, focused tests, docs, version files, and scripts/release-gate.sh.
  • Contract drift against .llm/BETA_19_TEST_DISCOVERY_AND_CONFORMANCE.md, docs/language/SPEC-v1.md, release notes, roadmaps, and README beta scope.
  • Cached diff status; no cached beta19 changes were present.

Read-only checks run:

  • git diff --check - passed.
  • git diff --cached --check - passed.
  • Stale-version scan for beta18/beta19 references - no blocking stale current release references found.
  • Conflict-marker and trailing-whitespace scans for the untracked beta19 contract/test files - passed.

Not run:

  • cargo fmt --check, focused cargo tests, full cargo test, and ./scripts/release-gate.sh; those commands write build artifacts, and this review was constrained to read-only commands except for the review file.

Verdict

Release-ready from this review. No blocking beta19 issues remain in the current working tree diff. The controller should still run the focused beta19 test suite and full release gate before tagging.