Hermeticum/slovo
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
acbe58f70e
slovo/.llm/reviews/BETA_13_RELEASE_REVIEW.md

3.0 KiB
Raw Blame History

1.0.0-beta.13 Release Review

Status: ready for publication after controller release gate.

Verdict

No blockers after controller catalog-count reconciliation.

Findings

No blocking findings remain.

Controller reconciliation note: the initial review used rg -o -h ... for the catalog count. On the local ripgrep version, -h prints help instead of meaning "no filename", so that command mixed help text with diagnostic codes. Using --no-filename gives the correct inventory: 358 .diag snapshots and 114 unique (code ...) values. The Current Golden Catalog table matches that 114-code snapshot set.

Scope Checked

  • Public docs in scope: README.md, docs/POST_BETA_ROADMAP.md, docs/language/DIAGNOSTICS.md, docs/language/MIGRATION_POLICY.md, docs/language/SPEC-v1.md, docs/language/ROADMAP.md, docs/language/RELEASE_NOTES.md, docs/compiler/ROADMAP.md, docs/compiler/RELEASE_NOTES.md, docs/language/STDLIB_API.md, and .llm/BETA_13_DIAGNOSTIC_CATALOG_AND_SCHEMA_POLICY.md.
  • Compiler/tooling in scope: compiler/src/diag.rs, compiler/src/main.rs, compiler/tests/diagnostics_schema_beta13.rs, compiler/tests/diagnostics_contract.rs, scripts/release-gate.sh, compiler/Cargo.toml, and compiler/Cargo.lock.
  • The compiler diff keeps diagnostic output shape limited to centralizing slovo.diagnostic schema name/version constants and reusing the version in artifact manifest diagnostics metadata.
  • docs/language/DIAGNOSTICS.md describes the current S-expression and JSON diagnostic shape, newline-delimited JSON stderr behavior, source-less JSON file:null and span:null, artifact-manifest diagnostic metadata, compatibility/migration classes, and explicit deferrals.
  • Release-facing stage wording consistently points at 1.0.0-beta.13 as the current stage and post-beta13 work as the next scope. Focused private-path and stale current-stage beta12 checks found no matches.

Verification Commands And Results

  • cargo fmt --check: passed.

  • cargo test --test diagnostics_schema_beta13: passed, 3 tests.

  • cargo test --test diagnostics_contract current_negative_cases_match_machine_diagnostic_snapshots: passed, 1 test.

  • git diff --check: passed.

  • rg -o 'snapshot: "\\.\\./tests/[^"]+\\.diag"' compiler/tests/diagnostics_contract.rs | wc -l: 358.

  • rg --files tests | rg '\\.diag$' | wc -l: 358.

  • rg --no-filename -o '\\(code [A-Za-z][A-Za-z0-9]*\\)' tests/*.diag | sed -E 's/^\\(code ([^)]+)\\)$/\\1/' | sort -u | wc -l: 114.

  • Comparing the unique snapshot code set with the Current Golden Catalog code set produced no differences, confirming the catalog table itself matches the 114-code snapshot set.

  • Focused rg check for private/local paths and stale current-stage beta12 release wording in the scoped public docs produced no matches.

  • ./scripts/release-gate.sh: passed after the beta13 release commit, including docs/API freshness, the focused beta13 diagnostics schema test, cargo fmt --check, full cargo test, ignored promotion gates, binary smoke, and LLVM smoke.