Hermeticum/slovo
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
b241a8a812
slovo/.llm/reviews/BETA_24_RELEASE_REVIEW.md

5.5 KiB
Raw Blame History

Beta24 Release Review

Verdict: PASS.

Findings

No blocking or non-blocking findings in the reviewed scope.

Scope Reviewed

  • compiler/src/project.rs package manifest diagnostics.
  • compiler/tests/package_workspace_discipline_beta24.rs.
  • scripts/release-gate.sh beta24 focused gate entry.
  • compiler/Cargo.toml and compiler/Cargo.lock version bump.
  • .llm/BETA_24_PACKAGE_MANIFEST_IDENTITY_AND_DEPENDENCY_DISCIPLINE.md.
  • README, language package/diagnostic/release/roadmap docs, compiler release/roadmap docs, and post-beta roadmap updates.

Acceptance Checklist

  • PASS: Duplicate package manifest keys now use package-scoped diagnostics through set_manifest_key(..., "PackageManifestInvalid", "package") for package identity keys. See compiler/src/project.rs:1505 through compiler/src/project.rs:1545 and compiler/src/project.rs:1752 through compiler/src/project.rs:1771.
  • PASS: Invalid dependency keys are rejected before graph validation with InvalidPackageDependencyName. See compiler/src/project.rs:1556 through compiler/src/project.rs:1572.
  • PASS: Duplicate dependency keys are rejected before graph validation with DuplicatePackageDependencyName, and invalid/duplicate dependency records are not added to the dependency graph. See compiler/src/project.rs:1573 through compiler/src/project.rs:1593.
  • PASS: Existing local-path-only dependency parsing and later dependency key/name matching remain in place. See compiler/src/project.rs:1594 through compiler/src/project.rs:1601, compiler/src/project.rs:1743 through compiler/src/project.rs:1749, and compiler/src/project.rs:2970 through compiler/src/project.rs:3005.
  • PASS: Focused tests cover duplicate package keys, invalid dependency keys, duplicate dependency keys, and a clean local dependency workspace. See compiler/tests/package_workspace_discipline_beta24.rs:11 through compiler/tests/package_workspace_discipline_beta24.rs:109.
  • PASS: scripts/release-gate.sh runs the beta24 focused test before full cargo test. See scripts/release-gate.sh:68 through scripts/release-gate.sh:82.
  • PASS: The compiler package version is aligned to 1.0.0-beta.24 in both Cargo files. See compiler/Cargo.toml:3 and compiler/Cargo.lock:7.
  • PASS: The beta24 contract defines diagnostics-only scope, explicit non-scope, acceptance criteria, and focused gates. See .llm/BETA_24_PACKAGE_MANIFEST_IDENTITY_AND_DEPENDENCY_DISCIPLINE.md:5 through .llm/BETA_24_PACKAGE_MANIFEST_IDENTITY_AND_DEPENDENCY_DISCIPLINE.md:79.
  • PASS: README identifies 1.0.0-beta.24 as current and describes the package manifest/dependency diagnostic hardening scope without claiming package-manager, runtime, language, or stdlib changes. See README.md:9 and README.md:27 through README.md:50.
  • PASS: docs/language/PACKAGES.md documents duplicate package manifest keys, invalid dependency keys, and duplicate dependency keys as beta package/workspace diagnostics. See docs/language/PACKAGES.md:59 through docs/language/PACKAGES.md:73 and docs/language/PACKAGES.md:111 through docs/language/PACKAGES.md:130.
  • PASS: docs/language/DIAGNOSTICS.md includes the new package/workspace diagnostic codes in the project/workspace catalog. See docs/language/DIAGNOSTICS.md:240 through docs/language/DIAGNOSTICS.md:279.
  • PASS: Language and compiler release notes describe beta24 as package manifest identity/dependency diagnostic hardening only. See docs/language/RELEASE_NOTES.md:44 through docs/language/RELEASE_NOTES.md:68 and docs/compiler/RELEASE_NOTES.md:15 through docs/compiler/RELEASE_NOTES.md:42.
  • PASS: Language/compiler roadmaps and post-beta roadmap mark beta24 as the current local package/workspace diagnostics slice with registry, lockfile, semver, publishing, optional/dev/target dependencies, ABI/layout, language, runtime, and stdlib work deferred. See docs/language/ROADMAP.md:11 through docs/language/ROADMAP.md:33, docs/compiler/ROADMAP.md:24 through docs/compiler/ROADMAP.md:38, docs/compiler/ROADMAP.md:722 through docs/compiler/ROADMAP.md:728, and docs/POST_BETA_ROADMAP.md:185 through docs/POST_BETA_ROADMAP.md:191.

Verification Commands

Ran:

git diff --check
cargo fmt --check
cargo test --test package_workspace_discipline_beta24
cargo test --test project_mode workspace_package_boundaries_are_diagnostics
cargo test --test project_mode
rg -n "beta\\.23|beta23|beta\\.24|beta24|1\\.0\\.0-beta\\.2[0-9]|current|Release state|Last updated" README.md docs/language/PACKAGES.md docs/language/DIAGNOSTICS.md docs/language/RELEASE_NOTES.md docs/language/ROADMAP.md docs/compiler/RELEASE_NOTES.md docs/compiler/ROADMAP.md docs/POST_BETA_ROADMAP.md .llm/BETA_24_PACKAGE_MANIFEST_IDENTITY_AND_DEPENDENCY_DISCIPLINE.md compiler/Cargo.toml compiler/Cargo.lock scripts/release-gate.sh

Result: all executed checks passed. The focused beta24 test reported 4 passed tests. The full project_mode suite reported 36 passed tests.

Final Gate Disposition

After this review, the controller ran the full release gate:

./scripts/release-gate.sh

Result: PASS. The gate completed docs/catalog checks, focused beta13-beta24 tests, full cargo test, ignored promotion smoke, ignored binary smoke, and ignored LLVM smoke.

Residual Risks

  • No release-blocking residual risks remain. The release gate regenerated and checked the standard-library API catalog; publication PDFs were not regenerated because this slice does not touch paper sources, and the gate verified that the required PDF artifacts are present.