slovo/.llm/reviews/BETA_16_RELEASE_REVIEW.md

56 lines
3.2 KiB
Markdown

# 1.0.0-beta.16 Release Review
Scope: `1.0.0-beta.16 String Scanning And Token Boundary Foundation`
Final verdict: ready for controller commit and final publication gate. I found no remaining blocking findings in the current worktree.
## Findings
No blocking findings.
Previously reported blockers are resolved:
- The unignored `promotion_gate_artifacts_are_aligned` stack overflow is fixed. The beta16 string runtime handlers are now extracted in `compiler/src/test_runner.rs` and dispatched from the runtime-symbol branch without re-entering the old recursive path in a way that overflows the vec_i32 import fixture.
- `.llm/BETA_16_STRING_SCANNING_AND_TOKEN_BOUNDARY_FOUNDATION.md` is now a combined Slovo/Glagol release scope rather than Slovo-side-only.
- `lib/std/README.md` now documents `byte_at_result`, `slice_result`, `starts_with`, `ends_with`, and the beta16 non-scope boundaries.
## Scope Confirmation
Confirmed: the beta16 candidate adds byte-oriented `std.string.byte_at_result`, `std.string.slice_result`, `std.string.starts_with`, and `std.string.ends_with`, with matching source facades, runtime entries, LLVM lowering, C runtime behavior, test-runner behavior, diagnostics inventory, examples, docs, release-gate coverage, and version bump.
Confirmed no beta16 claim for JSON parser, Unicode scalar/grapheme/display-width semantics, language-level slice/view syntax or borrowed substring views, generic collections, maps/sets, stable ABI/layout, stable stdlib/API freeze, tokenizers, object/array parsing, mutable strings, or performance claims. Matches for those terms are deferrals or explicit non-scope statements.
`docs/language/STDLIB_API.md` reflects the generated beta16 surface as 582 exported helper signatures total, with `std.string` at 30 exports including the four beta16 helpers.
## Verification
Passed:
- `cargo fmt --check`
- `cargo test --test standard_string_scanning_beta16`
- `cargo test --test diagnostics_contract`
- `cargo test --test standard_string_source_fallback_helpers_alpha`
- `cargo test --test standard_core_facade_source_search_alpha`
- `cargo test --test string_runtime`
- `cargo test --test promotion_gate -- --ignored`
- `cargo test --test promotion_gate promotion_gate_artifacts_are_aligned`
- `cargo test`
- `cargo test --test diagnostics_schema_beta13`
- `cargo test --test benchmark_suite_catalog_beta14`
- `cargo test --test reserved_generic_collection_beta15`
- `cargo test --test binary_smoke -- --ignored`
- `cargo test --test llvm_smoke -- --ignored`
- `bash -n scripts/install.sh`
- `bash -n scripts/render-stdlib-api-doc.sh`
- `scripts/render-stdlib-api-doc.sh`
- `git diff --check`
- stale current-stage beta15 scan
- local/private publication text scan across source/docs/tests/.llm
- required PDF artifact existence check
- `pdftotext` plus local/private publication text scan across required PDFs
Not run:
- Full `./scripts/release-gate.sh` before commit. The script intentionally requires the generated `docs/language/STDLIB_API.md` diff to already be committed, so running it on this dirty release candidate would produce a known false failure. Its cargo, shell syntax, generated-catalog, private-text, PDF, binary-smoke, and LLVM-smoke components were run manually above. Run the full script after committing beta16 and before tagging.